rahulbiswas876 commented on code in PR #2023:
URL: https://github.com/apache/streampipes/pull/2023#discussion_r1357835601
##########
streampipes-extensions/streampipes-processors-filters-jvm/src/main/java/org/apache/streampipes/processors/filters/jvm/processor/merge/MergeByTimeProcessor.java:
##########
@@ -40,10 +40,10 @@
public class MergeByTimeProcessor extends StreamPipesDataProcessor {
- private static final String TIMESTAMP_MAPPING_STREAM_1_KEY =
"timestamp_mapping_stream_1";
- private static final String TIMESTAMP_MAPPING_STREAM_2_KEY =
"timestamp_mapping_stream_2";
+ protected static final String TIMESTAMP_MAPPING_STREAM_1_KEY =
"timestamp_mapping_stream_1";
+ protected static final String TIMESTAMP_MAPPING_STREAM_2_KEY =
"timestamp_mapping_stream_2";
private static final String NUMBER_MAPPING = "number_mapping";
Review Comment:
addressed your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
