dominikriemer commented on code in PR #2024:
URL: https://github.com/apache/streampipes/pull/2024#discussion_r1358293655
##########
streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/adapters/iolink/IfmAlMqttAdapter.java:
##########
@@ -110,18 +110,26 @@ public void onAdapterStarted(IAdapterParameterExtractor
extractor,
for (int i = 0; i < ports.size(); i++) {
- var portResult = getMap(payload,
-
"/iolinkmaster/port[%s]/iolinkdevice/pdin".formatted(ports.get(i)));
- var eventData = (String) portResult.get("data");
-
- var parsedEvent = sensor.parseEvent(eventData);
- parsedEvent.put("timestamp", System.currentTimeMillis() + i);
- parsedEvent.put("port", "port" + ports.get(i));
- parsedEvent.put(SensorVVB001.IO_LINK_MASTER_SN, serialnumber);
-
- collector.collect(parsedEvent);
+ try {
+ var portResult = getMap(payload,
+
"/iolinkmaster/port[%s]/iolinkdevice/pdin".formatted(ports.get(i)));
Review Comment:
Can we check if the port exists here before fetching it?
##########
streampipes-extensions/streampipes-connect-adapters-iiot/src/main/java/org/apache/streampipes/connect/iiot/adapters/iolink/IfmAlMqttAdapter.java:
##########
@@ -110,18 +110,26 @@ public void onAdapterStarted(IAdapterParameterExtractor
extractor,
for (int i = 0; i < ports.size(); i++) {
- var portResult = getMap(payload,
-
"/iolinkmaster/port[%s]/iolinkdevice/pdin".formatted(ports.get(i)));
- var eventData = (String) portResult.get("data");
-
- var parsedEvent = sensor.parseEvent(eventData);
- parsedEvent.put("timestamp", System.currentTimeMillis() + i);
- parsedEvent.put("port", "port" + ports.get(i));
- parsedEvent.put(SensorVVB001.IO_LINK_MASTER_SN, serialnumber);
-
- collector.collect(parsedEvent);
+ try {
+ var portResult = getMap(payload,
+
"/iolinkmaster/port[%s]/iolinkdevice/pdin".formatted(ports.get(i)));
+ var eventData = (String) portResult.get("data");
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
