dominikriemer commented on code in PR #2193:
URL: https://github.com/apache/streampipes/pull/2193#discussion_r1396841863
##########
ui/src/app/editor/components/pipeline-element-options/pipeline-element-options.component.ts:
##########
@@ -227,4 +226,25 @@ export class PipelineElementOptionsComponent implements
OnInit, OnDestroy {
ngOnDestroy(): void {
this.pipelineElementConfiguredObservable.unsubscribe();
}
+
+ deepCopy(obj) {
+ const clone = {};
+
+ if (
+ typeof obj !== 'object' ||
+ typeof obj === undefined ||
+ obj === null ||
+ Array.isArray(obj) ||
Review Comment:
Just a question...why are arrays excluded here?
E.g., when called with a `PipelineElementConfig[]` object (line 164), it
seems the method returns the original input and not a deep copy of the list
including its elements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
