tenthe commented on code in PR #2197: URL: https://github.com/apache/streampipes/pull/2197#discussion_r1402978262
########## ui/cypress/tests/adapter/enhancedDeleteAdapter.smoke.spec.ts: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +import { AdapterBuilder } from '../../support/builder/AdapterBuilder'; +import { ConnectUtils } from '../../support/utils/connect/ConnectUtils'; +import { PipelineBuilder } from '../../support/builder/PipelineBuilder'; +import { PipelineElementBuilder } from '../../support/builder/PipelineElementBuilder'; +import { UserUtils } from '../../support/utils/UserUtils'; +import { PipelineUtils } from '../../support/utils/PipelineUtils'; + +const adapterName = 'simulator'; + +const adapterInput = AdapterBuilder.create('Machine_Data_Simulator') + .setName(adapterName) + .addInput('input', 'wait-time-ms', '1000') + .build(); + +const pipelineInput = PipelineBuilder.create('Pipeline Test') + .addSource(adapterName) + .addProcessingElement( + PipelineElementBuilder.create('field_renamer') + .addInput('drop-down', 'convert-property', 'timestamp') + .addInput('input', 'field-name', 't') + .build(), + ) + .addSink( + PipelineElementBuilder.create('data_lake') + .addInput('input', 'db_measurement', 'demo') + .build(), + ) + .build(); + +describe('Test Enhanced Adapter Deletion', () => { + // In the beginning, create the non-admin user + before(() => { + cy.initStreamPipesTest(); + UserUtils.addUser(UserUtils.adapterAndPipelineAdminUser); + cy.logout(); + }); + + // After the last test, let admin user clean up (delete the adapter, associated pipelines, and the non-admin user) + after(() => { Review Comment: Is this part of the test or is it only meant as clean up? If it is the latter, it can be removed. Before a test is started, the existing system is reset with `cy.initStreamPipesTest()`. If there were still StreamPipes resources in your tests, we should delete them. The code for the reset can be found in the class `ResetResource.java`. This ensures that all tests always have a clean environment, even if the previous test fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
