bossenti commented on PR #2207: URL: https://github.com/apache/streampipes/pull/2207#issuecomment-1825549512
I have adapted the asset files a bit, hope you are okay with it 🙂 I just tested it locally and have some last remarks: - You need to register your processor in the class `TransformationExtensionModuleExport`. Otherwise streampipes won't recognize it - Please align the id in `ProcessingElementBuilder`s `create()` with the name of the resources directory - The timezone parameter has a lot of values: ![Uploading image.png…]() I think we need to sort them at least alphabetically. In addition, I would suggest to use a dropdown menu as input dialog (I can help you here, in case you are not sure about how to achieve) Lastly, is my understanding correct that the timezone parameter should be optional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
