Hi,

+1 (binding).

*Environment:*

OS: Ubuntu 23.10 x86_64
mvn -version
Apache Maven 3.8.7
Maven home: /usr/share/maven
Java version: 22-ea, vendor: Private Build, runtime:
/usr/lib/jvm/java-22-openjdk-amd64
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-13-generic", arch: "amd64", family: "unix"
docker --version
Docker version 24.0.5, build 24.0.5-0ubuntu1
docker-compose --version
docker-compose version 1.29.2
npm -version
9.2.0

*Checked*:

   - [ok] Download all staged artifacts under the url specified in the
   release vote email
   - [ok] Verify the signature is correct
   - [ok] Check if the signature references an Apache email address
   - [ok] Verify the SHA512 checksum
   - [ok] Unzip the archive
   - [ok] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES,
   RELEASE_VALIDATION files in the extracted source bundle.
   - [ok] Run RAT
   - [ok*] Search for SNAPSHOT dependencies
   - [ok*] Build Backend
   - [ok] Build UI
   - [ok] Build and Run Test system on Docker

Minor remark: can not built with java 22.

Thanks Tim!

Lukas


Am Mo., 27. Nov. 2023 um 07:53 Uhr schrieb Grainier Perera <
[email protected]>:

> Hi,
>
> +1 (binding).
>
> *Environment:*
>
>    - *OS*: macOS 13.4
>    - *JDK*: openjdk version "17.0.8.1" 2023-08-24
>    - *Maven*: Apache Maven 3.9.4
>    - *NodeJS*: v20.8.0
>    - *NPM*: 10.1.0
>    - *Docker*: 24.0.2, build cb74dfc
>
> *Checked*:
>
>    - [ok] Download all staged artifacts under the url specified in the
>    release vote email
>    - [ok] Verify the signature is correct
>    - [ok] Check if the signature references an Apache email address
>    - [ok] Verify the SHA512 checksum
>    - [ok] Unzip the archive
>    - [ok] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES,
>    RELEASE_VALIDATION files in the extracted source bundle.
>    - [ok] Run RAT
>    - [ok*] Search for SNAPSHOT dependencies
>    - [ok*] Build Backend
>    - [ok] Build UI
>    - [ok] Build and Run Test system on Docker
>
> *Few minor observations:*
> - I also came across SNAPSHOT references:
>
> > .//streampipes-client-python/streampipes/endpoint/api/version.py:62:
> >  {'backend_version': '0.92.0-SNAPSHOT'}
> > .//streampipes-client-python/streampipes/client/client.py:168:        #
> > remove SNAPSHOT-suffix if present
> > .//streampipes-client-python/streampipes/client/client.py:169:
> >  sp_version = version_dict["backend_version"].replace("-SNAPSHOT", "")
> > .//streampipes-pipeline-management/pom.xml:38:<!--
> >  <version>0.93.0-SNAPSHOT</version>-->
> > .//RELEASE_NOTES.md:82:  0.92.0-SNAPSHOT not found
> >
> .//streampipes-extensions/streampipes-pipeline-elements-experimental-flink/pom.xml:24:
> >        <version>0.93.0-SNAPSHOT</version>
> >
> .//streampipes-extensions/streampipes-pipeline-elements-experimental-flink/pom.xml:38:
> >            <version>0.93.0-SNAPSHOT</version>
> >
> .//streampipes-extensions/streampipes-pipeline-elements-experimental-flink/pom.xml:43:
> >            <version>0.93.0-SNAPSHOT</version>
>
>
> - Also, `maven-javadoc-plugin` is configured with `<source>11</source>`, so
> during the build I came across several javadoc errors like. But this will
> not break the build.
>
> > [ERROR] MavenReportException: Error while generating Javadoc:
> > Exit code: 1
> >
> /Users/grainier/NoBackup/sp/rc1/apache-streampipes-0.93.0/streampipes-model/src/main/java/org/apache/streampipes/model/configuration/DefaultMessagingSettings.java:32:
> > error: switch expressions are not supported in -source 11
> >       protocolList = switch
> > (env.getPrioritizedProtocol().getValueOrDefault().toLowerCase()) {
>
>
> Thanks,
> Grainier Perera.
>
>
> On Mon, 27 Nov 2023 at 02:18, Dominik Riemer <[email protected]
> >
> wrote:
>
> > Hi,
> >
> > +1 (binding).
> >
> > I checked:
> >
> > [ok] Download all staged artifacts under the url specified in the release
> > vote email
> > [ok] Verify the signature is correct
> > [ok] Check if the signature references an Apache email address
> > [ok] Verify the SHA512 checksum
> > [ok] Unzip the archive
> > [ok] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES,
> > RELEASE_VALIDATION files in the extracted source bundle.
> > [ok] Run RAT
> > [ok*] Search for SNAPSHOT dependencies
> > [ok] Build Backend
> > [ok] Build UI
> > [ok]Build and Run Test system on Docker
> >
> > As I've written in the discussion thread, I was not able to reproduce any
> > errors when upgrading the system, so I guess from my side it's ok unless
> > anyone else reports problems.
> >
> > Tested under Windows 11, JDK 17.
> >
> > * I found a SNAPSHOT reference in the versions.py file, but this was only
> > mentioned as an example and another one in the experimental Flink
> pipeline
> > elements which are not part of the build, so it's ok.
> >
> > Thanks Tim for managing the release!
> >
> > Dominik
> >
> >
> >
> >
> > -----Original Message-----
> > From: Tim Bossenmaier <[email protected]>
> > Sent: Tuesday, November 21, 2023 8:58 AM
> > To: [email protected]
> > Subject: [VOTE] Apache StreamPipes 0.93.0 RC1 release
> >
> > Hi all,
> >
> > Apache StreamPipes 0.93.0 has been staged and it’s time to vote on
> > accepting it for release.
> > Voting will be open for at least 72 hours.
> > A minimum of 3 binding +1 votes and more binding +1 than binding -1 are
> > required to pass, but everyone is welcome to vote!
> >
> > One artifact is relevant for this vote:
> >
> > streampipes, staged at [1], available in Nexus at [2], release tag:
> > release/0.93.0, hash for the release tag:
> > 39d9986f41b93dbe9060c38b05ccf74e8e349ff6
> >
> > Per [3] "Before voting +1, PMC members are required to download the
> signed
> > source code package, compile it as provided, and test the resulting
> > executable on their own platform, along with also verifying that the
> > package meets the requirements of the ASF policy on releases."
> >
> > A release validation guide is available at [4]. The KEYS file is
> available
> > at [5]
> >
> > [ ] +1 accept (indicate what you validated - e.g. performed the checklist
> > at the end of [4]) [ ] -1 reject (explanation required)
> >
> > Thanks for taking your time for validating this release!
> >
> > Best
> > Tim
> >
> >
> > [1] https://dist.apache.org/repos/dist/dev/streampipes/0.93.0/rc1/
> > [2]
> >
> >
> https://repository.apache.org/content/repositories/orgapachestreampipes-1027
> > [3] https://www.apache.org/dev/release.html#approving-a-release
> > [4]
> >
> >
> https://cwiki.apache.org/confluence/display/STREAMPIPES/Validating+a+release
> > [5] https://downloads.apache.org/streampipes/KEYS
> >
>

Reply via email to