dominikriemer commented on code in PR #2515:
URL: https://github.com/apache/streampipes/pull/2515#discussion_r1515156334
##########
streampipes-extensions/streampipes-sinks-notifications-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/slack/SlackNotificationSink.java:
##########
@@ -56,10 +55,9 @@ public class SlackNotificationSink extends
StreamPipesDataSink {
private String originalMessage;
@Override
- public DataSinkDescription declareModel() {
-
+ public DataSinkBuilder declareModelWithoutSilentPeriod() {
return DataSinkBuilder
- .create("org.apache.streampipes.sinks.notifications.jvm.slack", 0)
+ .create("org.apache.streampipes.sinks.notifications.jvm.slack", 1)
Review Comment:
Does it make sense to extract the ID to a public static variable so that it
can be reused in the Migration classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
