nine03 commented on PR #2557: URL: https://github.com/apache/streampipes/pull/2557#issuecomment-1999413906
> Hi @nine03, thank you for your PR. Can you please update your local git repository to the new `dev` branch. I checked the code out and it looks like it is using junit4 instead of junit5. I could not run it locally. > > Yes, you are right, a lot has changed. But now it is also possible to simplify the test code a lot. Especially how to instantiate the test class `BooleanCounterProcessor`. Therefore you can have a look at the test of `TestBooleanFilterProcessor`. Here I tried to clean up the code a bit. > > Let me know if you have any questions or challenges. I hope this explanation helps a little. Hi @tenthe, I have merged the changes from 2545-testbooleancounterprocessor branch into the dev branch as you requested. Please take a look when you have time. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
