tenthe commented on code in PR #2569:
URL: https://github.com/apache/streampipes/pull/2569#discussion_r1527897552
##########
ui/src/app/data-explorer/components/widgets/time-series-chart/config/time-series-chart-widget-config.component.ts:
##########
@@ -146,6 +146,16 @@ export class TimeSeriesChartWidgetConfigComponent extends
BaseWidgetConfig<
},
);
config.showSpike ??= true;
+ config.leftAxis ??= {
Review Comment:
Does this mean that automatic scaling is active and a minimum and a maximum
are set? Or am I misunderstanding this? If this is the case, why do both have
to be set?
##########
ui/src/app/data-explorer/models/dataview-dashboard.model.ts:
##########
@@ -104,6 +104,12 @@ export interface FieldProvider {
nonNumericFields: DataExplorerField[];
}
+export interface AxisConfig {
+ axisScaleMode: boolean;
Review Comment:
What is the axisScaleMode? what do you think about renaming it to
`autoScaleActive`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
