dominikriemer commented on code in PR #2653:
URL: https://github.com/apache/streampipes/pull/2653#discussion_r1542496299
##########
streampipes-model/src/main/java/org/apache/streampipes/model/staticproperty/RemoteOneOfStaticProperty.java:
##########
@@ -52,7 +52,7 @@ public RemoteOneOfStaticProperty(String internalName, String
label, String descr
this.valueFieldName = valueFieldName;
this.labelFieldName = labelFieldName;
this.descriptionFieldName = descriptionFieldName;
- this.valueRequired = valueRequired;
+ this.optional = valueRequired;
Review Comment:
@tenthe `RemoteOneOfStaticProperty` isn't used anymore and deprecated since
2019, I propose to open a separate PR after merging this one to delete the
property completely. The change here is just due to automatic refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
