dominikriemer commented on code in PR #2645:
URL: https://github.com/apache/streampipes/pull/2645#discussion_r1542646163
##########
streampipes-service-extensions/src/main/java/org/apache/streampipes/service/extensions/StreamPipesExtensionsServiceBase.java:
##########
@@ -98,22 +126,50 @@ private void registerService(SpServiceRegistration
serviceRegistration) {
new CoreRequestSubmitter().submitRegistrationRequest(client,
serviceRegistration);
}
- protected List<SpServiceTag> getServiceTags() {
- List<SpServiceTag> tags = new ArrayList<>();
+ protected Set<SpServiceTag> getServiceTags(Set<ExtensionItemDescription>
extensions) {
+ Set<SpServiceTag> tags = new HashSet<>();
if (DeclarersSingleton.getInstance().getServiceDefinition() != null) {
tags.add(SpServiceTag.create(SpServiceTagPrefix.SP_GROUP,
DeclarersSingleton.getInstance().getServiceDefinition().getServiceGroup()));
}
- tags.addAll(getExtensionsServiceTags());
+ tags.addAll(getExtensionsServiceTags(extensions));
return tags;
}
+ private Set<ExtensionItemDescription> getAllExtensions() {
Review Comment:
I created a separate class to provide extensions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
