tenthe commented on code in PR #2803:
URL: https://github.com/apache/streampipes/pull/2803#discussion_r1584733421
##########
streampipes-commons/src/main/java/org/apache/streampipes/commons/constants/Envs.java:
##########
@@ -54,6 +54,7 @@ public enum Envs {
// Time Series Storage
+ SP_TS_STORAGE("SP_TS_STORAGE", "influxDB"),
Review Comment:
```suggestion
SP_TS_STORAGE("SP_TS_STORAGE", "influxdb"),
```
##########
streampipes-data-explorer-management/src/main/java/org/apache/streampipes/dataexplorer/management/DataExplorerDispatcher.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.streampipes.dataexplorer.management;
+
+import org.apache.streampipes.commons.environment.Environments;
+import org.apache.streampipes.dataexplorer.api.IDataExplorerManager;
+import org.apache.streampipes.dataexplorer.influx.DataExplorerManagerInflux;
+
+public enum DataExplorerDispatcher {
Review Comment:
Does it make sense to change this to a class that we can more easily mock
for testing instead of a singleton?
##########
streampipes-data-explorer-management/src/main/java/org/apache/streampipes/dataexplorer/management/SupportedDataExplorerStorages.java:
##########
@@ -16,10 +16,16 @@
*
*/
+package org.apache.streampipes.dataexplorer.management;
+
/**
- * This package contains classes that have direct dependencies on
InfluxDB-specific implementations.
- * To enhance code organization and promote agnostic design, these classes are
slated for migration to other modules,
- * such as 'streampipes-data-explorer' or 'streampipes-data-explorer-api'.
- * Pending migration, they are temporarily housed within this package.
+ * Class containing constants for supported time series storage
implementations.
+ * <p>
+ * Supported time series storage implementations:
+ * <ul>
+ * <li>{@link #INFLUX_DB}: Represents the InfluxDB time series storage
implementation.</li>
+ * </ul>
*/
-package org.apache.streampipes.dataexplorer.influx.migrate;
\ No newline at end of file
+public class SupportedDataExplorerStorages {
+ public static final String INFLUX_DB = "influxDB";
Review Comment:
influxdb?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
