tenthe commented on code in PR #3075:
URL: https://github.com/apache/streampipes/pull/3075#discussion_r1698007328
##########
ui/src/app/login/components/login/login.component.html:
##########
@@ -91,6 +91,35 @@ <h5 class="login-error">
<a [routerLink]="['/register']">Create new account</a>
</div>
</div>
+ <div
Review Comment:
Does it make sense to put this in its own component?
##########
streampipes-model-client/src/main/java/org/apache/streampipes/model/client/user/UserAccount.java:
##########
@@ -39,13 +41,16 @@ public class UserAccount extends Principal {
protected boolean hideTutorial;
protected boolean darkMode = false;
+ protected String provider;
Review Comment:
What exactly is a provider? Also add a description to UserRegistrationData
##########
streampipes-rest/src/main/java/org/apache/streampipes/rest/impl/Authentication.java:
##########
@@ -157,4 +160,22 @@ private JwtAuthenticationResponse
makeJwtResponse(org.springframework.security.c
String jwt = new JwtTokenProvider().createToken(auth);
return new JwtAuthenticationResponse(jwt);
}
+
+ private UiOAuthSettings makeOAuthSettings() {
Review Comment:
Can we move this to a seperate class? I would also suggest to put it into
another module. Which would be the best module for this?
##########
streampipes-commons/src/main/java/org/apache/streampipes/commons/environment/model/OAuthConfiguration.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.streampipes.commons.environment.model;
+
+public class OAuthConfiguration {
Review Comment:
Can we change this to a record?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
