bossenti commented on code in PR #3148:
URL: https://github.com/apache/streampipes/pull/3148#discussion_r1720714741
##########
streampipes-client-python/streampipes/functions/utils/data_stream_generator.py:
##########
@@ -48,11 +51,26 @@ class RuntimeType(Enum):
INTEGER = "integer"
LONG = "long"
+class SemanticType(Enum):
Review Comment:
What is `SemanticType` used for?
I can't find any usage
##########
streampipes-client-python/streampipes/functions/utils/data_stream_generator.py:
##########
@@ -117,3 +136,35 @@ def create_data_stream(
data_stream.element_id = sanitized_stream_id
return data_stream
+
+# TODO Use an more general approach to create a data stream
+@deprecated('deprecated; please use "compose_data_stream" instead.')
Review Comment:
Could you please adapt the tests that use `create_data_stream` as well?
In addition, it would be great to have some dedicated tests for the new
`compose_data_stream` function, if you are open to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
