tenthe commented on PR #3168: URL: https://github.com/apache/streampipes/pull/3168#issuecomment-2306433567
Hi @IsaakKrut, good questions. Here are some thoughs from my side. **Propagation changes to AdapterDescription**: Propagating changes to the event schema directly to `AdapterDescription` could be problematic, as it might require modifications to the adapter itself, which might be different for each adapter type. Currently we think about that adapters should manage their own event schemas, which would change how we display event streams and adapter instances in the pipeline editor. Then pipelines could either have a data stream or an adapter as a data source. Currently, each adapter creates a data stream as a seperate object that needs to be kept in sync. I suggest we discuss this further in a separate issue. **Updating DataStream**: Regarding this PR I suggest to propagate event schema changes in the `DataStream` through the pipeline, similar to how we handle adapter updates. Check `AdapterResource.performPipelineMigrationPreflight()` for reference, and the update logic is in `AdapterUpdateManagement.updateAdapter` at line 75. Feel free to share your thoughts or ask any questions. I'm also not entirely sure what the best solution is, so we can discuss this further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
