IsaakKrut commented on PR #3195: URL: https://github.com/apache/streampipes/pull/3195#issuecomment-2316406561
Hi @tenthe, I implemented the front-end changes for adapter notifications. Looking for help with back-end. 1. I am currently facing an issue when the adapter version is lower than the provided migration's. Health status and notifications are being persisted but the running state is not. I expected WorkerRestClient.stopStreamAdapter to stop the adapter, but I end up with an adapter still in running state, but with the health status and notifications. 2. Also, please take a look if the back-end logic is updated in the right place. I've updated AdapterMigrationManager.handleMigrations(). 3. Let me know what you think about the set of health statuses(same as on the pipeline) and if you think they should be set anywhere else in the code. Maybe something should be added to handle old elements without the AdapterHealthStatus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
