tenthe commented on code in PR #3354: URL: https://github.com/apache/streampipes/pull/3354#discussion_r1861766468
########## streampipes-extensions/streampipes-connectors-opcua/src/main/java/org/apache/streampipes/extensions/connectors/opcua/config/security/KeyStoreLoader.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.streampipes.extensions.connectors.opcua.config.security; + +import org.apache.streampipes.commons.environment.Environment; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.InputStream; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.Key; +import java.security.KeyPair; +import java.security.KeyStore; +import java.security.PrivateKey; +import java.security.PublicKey; +import java.security.cert.X509Certificate; +import java.util.Arrays; + +public class KeyStoreLoader { + + private static final String CLIENT_ALIAS = "apache-streampipes"; + + private static final Logger LOG = LoggerFactory.getLogger(KeyStoreLoader.class); + + private X509Certificate[] clientCertificateChain; + private X509Certificate clientCertificate; + private KeyPair clientKeyPair; + + KeyStoreLoader load(Environment env, + Path securityDir) throws Exception { + var keyStore = KeyStore.getInstance("PKCS12"); + var keyStoreFile = env.getOpcUaKeystoreFile().getValueOrDefault(); + var keyStorePassword = env.getOpcUaKeystorePassword().getValueOrDefault(); + Path serverKeyStore = securityDir.resolve(keyStoreFile); + char[] serverKeyStorePassword = keyStorePassword.toCharArray(); + + LOG.info("Loading KeyStore at {}", serverKeyStore); + + try (InputStream in = Files.newInputStream(serverKeyStore)) { + keyStore.load(in, serverKeyStorePassword); + } + + Key clientPrivateKey = keyStore.getKey(CLIENT_ALIAS, serverKeyStorePassword); + if (clientPrivateKey instanceof PrivateKey) { + clientCertificate = (X509Certificate) keyStore.getCertificate(CLIENT_ALIAS); + + clientCertificateChain = Arrays.stream(keyStore.getCertificateChain(CLIENT_ALIAS)) + .map(X509Certificate.class::cast) + .toArray(X509Certificate[]::new); + + PublicKey serverPublicKey = clientCertificate.getPublicKey(); + clientKeyPair = new KeyPair(serverPublicKey, (PrivateKey) clientPrivateKey); + } + + return this; + } + + X509Certificate getClientCertificate() { Review Comment: same here ########## streampipes-extensions/streampipes-connectors-opcua/src/main/java/org/apache/streampipes/extensions/connectors/opcua/config/security/KeyStoreLoader.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.streampipes.extensions.connectors.opcua.config.security; + +import org.apache.streampipes.commons.environment.Environment; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.InputStream; +import java.nio.file.Files; +import java.nio.file.Path; +import java.security.Key; +import java.security.KeyPair; +import java.security.KeyStore; +import java.security.PrivateKey; +import java.security.PublicKey; +import java.security.cert.X509Certificate; +import java.util.Arrays; + +public class KeyStoreLoader { + + private static final String CLIENT_ALIAS = "apache-streampipes"; + + private static final Logger LOG = LoggerFactory.getLogger(KeyStoreLoader.class); + + private X509Certificate[] clientCertificateChain; + private X509Certificate clientCertificate; + private KeyPair clientKeyPair; + + KeyStoreLoader load(Environment env, Review Comment: Is the access modifier missing here? This is a public class, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
