heisenbergs-uncertainty commented on PR #3640: URL: https://github.com/apache/streampipes/pull/3640#issuecomment-2936498948
> Hi @heisenbergs-uncertainty, > > Thanks a lot for the PR — these are great new processing elements, and your description makes it easy to review. > > * For unit tests, you can use the `ProcessingElementTestExecutor` helper class. > * See `TransformToBooleanProcessorTest` or `NumericalFilterProcessorTest` for examples. > > Would you like to add some unit tests for your elements? Feel free to reach out if you have any questions or suggestions for improving the test framework. > > Hope this helps! Hey @tenthe! Thank you for the testing recommendation, that was super useful and made writing the tests much simpler. Props to whoever wrote that suite! I have gone ahead and added unit tests for the processors and made quite a few updates that they helped me catch. From my testing it should be good to go at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
