tenthe commented on PR #3648:
URL: https://github.com/apache/streampipes/pull/3648#issuecomment-2957992544

   Hi @Anush008,
   
   thanks a lot for the PR — the code looks good.
   I accidentally merged it before leaving one minor comment:
   
   You used the abstract class `StreamPipesDataSink`, but we now use the 
interface `IStreamPipesDataSink` as part of the updated API. Could you please 
update the implementation accordingly in a follow-up PR?
   
   Please let me know if you need any help.
   
   Thanks again!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to