tenthe commented on PR #3669: URL: https://github.com/apache/streampipes/pull/3669#issuecomment-2969545611
Hi @heisenbergs-uncertainty, the processor includes quite a bit of logic, so it took some time to fully understand. I really appreciate that it's implemented as a generic processor, which makes it reusable across different use cases. Just to confirm: the processor starts emitting events once a condition (e.g., value is `true`) is met continuously for a specified duration (e.g., 1 minute) – is that correct? Here are a few suggestions and comments: * The icon is quite colorful – could we switch to a slightly simpler design? * Regarding the AI-generated image: I'm not sure if we can use this in an Apache project. * On your question about the time trigger: maybe @grainier can help. He implemented the `RateLimitProcessor`, which also supports a time window and cron-based triggering. Any thoughts on this, @grainier? * In general, emitting events based on a time trigger (independent of input events) should be fine, as the downstream processor subscribes only to the emitted events * For now, if it's ok with you, could you provide the unit tests that don't rely on the time-based trigger? Lastly, about the Java version – it would be great to update this across the whole project. Let's track that in a separate issue. Cheers, Philipp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
