GauiPower opened a new pull request, #3700:
URL: https://github.com/apache/streampipes/pull/3700
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us
incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/community/get-involved/
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title
...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
`[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the
`Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
This pr is going to be the start of the transition from Material 2 to
Material 3. The main aspects of switching to Material 3 are a better dark mode
implementation and the use of [System
Variables](https://material.angular.dev/guide/system-variables). Currently
there are for example different background colors (--color-bg-0 to
--color-bg-4) but no definition, when to use which. This results in the problem
that in dark mode many things break.
The current plan is:
1. Add Material 3 so it can be used.
2. Make sure the Material 3 theme looks like the current theme in all sub
menus.
3. Make use of overrides so the variables like $sp-color-primary get also
used from the Material 3 theme.
4. Change all references to the new Material 3 system variables.
5. Change the dark mode so it uses the color-scheme attribute instead of css
classes.
6. Remove the old Material 2 code that is no longer being used.
The goal is to make the UI look the same and be compatible with the current
_variables.scss.
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
