tenthe commented on code in PR #3942:
URL: https://github.com/apache/streampipes/pull/3942#discussion_r2546268648
##########
streampipes-rest/src/main/java/org/apache/streampipes/rest/impl/admin/ExportProviderConfigurationResource.java:
##########
@@ -48,14 +59,72 @@ public ResponseEntity<List<ExportProviderSettings>>
getExportProviderConfigurati
}
@GetMapping(value = "/{providerId}", produces =
MediaType.APPLICATION_JSON_VALUE)
-@PreAuthorize(AuthConstants.IS_ADMIN_ROLE)
-public ResponseEntity<ExportProviderSettings>
getExportProviderSettingById(@PathVariable String providerId) {
+ @PreAuthorize(AuthConstants.IS_ADMIN_ROLE)
+ public ResponseEntity<ExportProviderSettings>
getExportProviderSettingById(@PathVariable String providerId) {
return
getSpCoreConfigurationStorage().get().getExportProviderSettings().stream()
.filter(setting ->
setting.getProviderId().equalsIgnoreCase(providerId))
.findFirst()
.map(ResponseEntity::ok)
.orElse(ResponseEntity.notFound().build());
-}
+ }
+
+ @GetMapping(value = "/test/{providerId}", produces =
MediaType.APPLICATION_JSON_VALUE)
+ @PreAuthorize(AuthConstants.IS_ADMIN_ROLE)
+ public ResponseEntity<?> testExportProviderSettingById(@PathVariable String
providerId) {
+ // Get Export Provider Settings
+ Optional<ExportProviderSettings> exportProviderSetting =
getSpCoreConfigurationStorage().get()
Review Comment:
Can you move this class into a service class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
