tenthe commented on code in PR #3991:
URL: https://github.com/apache/streampipes/pull/3991#discussion_r2571585641
##########
ui/src/app/data-explorer-shared/services/chart-panel-can-deactivate-guard.service.ts:
##########
@@ -28,12 +28,26 @@ import { SupportsUnsavedChangeDialog } from
'../models/dataview-dashboard.model'
@Injectable({ providedIn: 'root' })
export class ChartPanelCanDeactivateGuard {
constructor(private router: Router) {}
+ checkQueryParams(queryParams: { [key: string]: any }): boolean {
+ const { editMode, startDate, endDate } = queryParams;
+ return (
+ editMode !== undefined &&
+ editMode !== null &&
+ startDate !== undefined &&
+ startDate !== null &&
+ endDate !== undefined &&
+ endDate !== null
Review Comment:
```suggestion
editMode &&
startDate &&
endDate
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
