aviralnull commented on PR #4156: URL: https://github.com/apache/streampipes/pull/4156#issuecomment-3871184031
@dominikriemer - Fair point, and I apologize for the messy PR. To be honest, I used AI to help with parts of this but didn't verify the generated code against the actual codebase before submitting. That's on me - I should have caught that it was creating methods that don't exist in StreamPipes. I am genuinely interested in fixing this issue though. Looking at the stack trace, the error flows through ConversionUtils.findProperty() at line 91, then ToOriginalSchemaConverter.visit() and MoveRuleDescription.accept(). I'm just not clear on where the validation should actually go - in findProperty() itself to handle missing properties, or earlier in the flow before transformation happens? Are there existing validation patterns I should follow? I'll dig into the actual code properly this time and come back with a real fix that fits the existing structure. Thanks for the feedback - I appreciate you taking the time to point this out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
