Jayyadav1903 opened a new pull request, #4165:
URL: https://github.com/apache/streampipes/pull/4165
## Fix: Siemens S7 Adapter Next Button Disabled Without Visible Requirement
### Problem
When configuring the **Siemens S7 (Basic)** adapter, enabling *Advanced
options* causes the **Next** button to remain disabled until the
`controller-type` field is set.
However:
- `controller-type` is currently located under *Advanced* options
- There is no indication that this field is required
- Other advanced options appear optional
This creates a confusing UX where progression is blocked by a **hidden
required field**.
---
### Solution (UX Clarification)
This PR implements **Option A** by making the requirement explicit:
- The `controller-type` option is moved from the *Advanced* options group to
the *Required* options group for the Siemens S7 adapter
- The field is now immediately visible in the main configuration step
- Users can clearly see that the field is required and why the Next button
is disabled
This approach preserves existing validation logic and avoids relaxing
constraints that could lead to runtime errors.
---
### Implementation Details
- Modified `AdapterConfigurationProvider.java`
- In `makeConfig`, when the protocol driver is **S7**:
- Locate the `controller-type` option in the *Advanced* options
- Move it into the *Required* options group
- No backend validation logic was changed
- No other adapters are affected
---
### Verification
#### Manual Verification
1. Open the Adapter Wizard
2. Select **Siemens S7 (Basic)**
3. Observe that `controller-type` is visible in the main configuration view
4. Leave it empty → field is marked as required and **Next** is disabled
5. Fill in the field → **Next** button becomes enabled
---
### Scope & Risk
- **Scope:** UI configuration metadata only
- **Risk:** Low
- **Backward compatibility:** Fully preserved
This change makes an existing requirement visible and understandable without
changing adapter behavior.
---
### Related
- Fixes #3493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
