dominikriemer commented on code in PR #4288:
URL: https://github.com/apache/streampipes/pull/4288#discussion_r2981977691
##########
ui/src/app/connect/components/adapter-details/adapter-details-metrics/adapter-details-metrics.component.ts:
##########
@@ -61,13 +61,13 @@ export class SpAdapterDetailsMetricsComponent
{
adapterMetrics: SpMetricsEntry;
- constructor(
- currentUserService: CurrentUserService,
- activatedRoute: ActivatedRoute,
- adapterService: AdapterService,
- adapterMonitoringService: AdapterMonitoringService,
- breadcrumbService: SpBreadcrumbService,
- ) {
+ constructor() {
+ const currentUserService = inject(CurrentUserService);
Review Comment:
for abstract classes, we can inject the services in the abstract class and
mark them as protected to avoid super
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
