-1 binding… TL;DR failing unit tests that require changes to project
artifacts to overcome. PR coming.
——
I ran into problems building on my mac with mvn -v:
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T10:41:47-06:00)
Maven home: /Users/Shared/apache-maven-3.3.9
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_111.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.4", arch: "x86_64", family: "mac"
Failure was:
[INFO] streams-schema-activitystreams ..................... FAILURE [
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test)
on project streams-schema-activitystreams: ExecutionException
org.apache.maven.surefire.util.internal.StringUtils.requireNonNull(Ljava/lang/Object;)Ljava/lang/Object;
-> [Help 1]
What’s curious about this error is it originates outside our test code in
this module.
On a hunch I upgraded ${surefire.plugin.version} to latest version in
pom.xml and that fixed it.
Also encountered one other failing test caused by changes outside our
control.
org.apache.streams.monitoring.persist.impl.BroadcastMessagePersisterTest.testFailedPersist()
contains a URL that has begun returning a 200 with body “Not Found!”
instead of a 404.
Changing the URL to point at a non-registered domain instead of at
url.com got me through this problem.
——
I’ll submit these changes as two PRs shortly. If anyone can suggest a
way I can see all the unit tests pass without touching project
artifacts I’ll change my vote but I doubt that is possible.
Steve
On May 31, 2018 at 7:42 PM, Suneel Marthi <[email protected]> wrote:
+1 binding
1. Verified checksums and sigs
2. Downloaded src archive and did a clean build - all tests pass
Please remove the MD5 sigs when finalizing the release.
On Thu, May 31, 2018 at 6:27 PM, Joey Frazee <[email protected]> wrote:
I am pleased to be calling a vote for the release of Apache Streams 0.6.0.
Apache Streams 0.6.0 includes the following fixes and improvements:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12314320&version=12342993
This release candidate is based on streams-0.6.0-RC1 (3a57c3c):
https://github.com/apache/streams/releases/tag/streams-0.6.0-RC1
https://gitbox.apache.org/repos/asf?p=streams.git;a=commit;h=
3a57c3c3a845b1e64c37303cb3aaa742cfa2185f
The release candidate source archive, signatures and digests are at:
https://repository.apache.org/content/repositories/
orgapachestreams-1027/org/apache/streams/apache-streams/0.6.0/
And, the full staging repo and release artifacts can be found here:
https://repository.apache.org/content/repositories/
orgapachestreams-1027/
The release artifacts have been signed with https://people.apache.org/
keys/committer/jfrazee.asc and the project KEYS file can be found at
https://raw.githubusercontent.com/apache/streams/master/KEYS
Git ID: 3a57c3c3a845b1e64c37303cb3aaa742cfa2185f
MD5: 052d4c081cf62b6262a56b16729aa6b2
SHA1: 8fbe605ca4fa0e0abeef43cc0977a642b1c6761a
See streams/release.sh for information on how to build and run with
integration tests.
The vote will be open for at least 72 hours.
[ ] +1 approve the release of Apache Streams 0.6.0
[ ] +0 no opinion (and reason why)
[ ] -1 disapprove (and reason why)
