steveblackmon commented on code in PR #6: URL: https://github.com/apache/streams-activitypub/pull/6#discussion_r1493954599
########## pom.xml: ########## @@ -553,19 +563,34 @@ <artifactId>jsonschema2pojo-maven-plugin</artifactId> <version>${jsonschema2pojo.version}</version> <configuration> + <addCompileSourceRoot>true</addCompileSourceRoot> <annotationStyle>none</annotationStyle> <customAnnotator>org.apache.streams.plugins.JuneauPojoAnnotator</customAnnotator> <generateBuilders>true</generateBuilders> <includeGeneratedAnnotation>false</includeGeneratedAnnotation> - <sourceDirectory>${project.basedir}/src/main/jsonschema</sourceDirectory> - <outputDirectory>${project.build.directory}/generated-sources/pojo</outputDirectory> </configuration> <executions> <execution> - <phase>generate-sources</phase> + <id>generate-sources</id> + <phase>none</phase> + <goals> + <goal>generate</goal> + </goals> + <configuration> + <sourceDirectory>${project.basedir}/src/main/jsonschema</sourceDirectory> + <outputDirectory>${project.build.directory}/generated-sources/pojo</outputDirectory> + </configuration> + </execution> + <execution> + <id>generate-test-sources</id> + <phase>none</phase> <goals> Review Comment: these phase=none let the parent pom do all the configuration and child modules enable one or both executions by settings phase!=none -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streams.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org