steveblackmon commented on code in PR #6:
URL: https://github.com/apache/streams-activitypub/pull/6#discussion_r1493963372
##########
streams-activitypub-webapp/src/test/scala/org/apache/streams/activitypub/webapp/test/ActivityPubWebappTestSuiteExtension.scala:
##########
@@ -81,24 +76,13 @@ class ActivityPubWebappTestSuiteExtension extends
ParameterResolver with BeforeA
override def afterAll(extensionContext: ExtensionContext): Unit = {
LOGGER.info("afterAll()")
- try {
- tomcat.stop();
- } catch {
- case e: Exception => LOGGER.error("Exception while stopping tomcat", e);
- } finally {
- try {
- tomcat.destroy();
- } catch {
- case e: Exception => LOGGER.error("Exception while destoying tomcat",
e);
- }
- }
}
Review Comment:
if BeforeAllCallback and AfterAllCallback could be activated only by the
'TestSuite' starts and stops vs the test classes that compose the test suite,
this code should return. couldn't figure out how to make this happen yet though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@streams.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
