Ryan, These changes are very positive - l'm certain this approach will allow the line counts of existing and future modules to shrink. Having a single process stream builder with semantics that mirror storm's is a major improvement over creating a bunch of threads and then starting them all.
I think we may want to split out some of what you added to streams-core into a new module, maybe streams-runtime-jvm, setting up a pattern whereby the execution framework can be chosen by the implementer from one of several options, but that can wait until later. I've created a branch, STREAMS-26, with your patch applied and several modules (provider-twitter, persist-elasticsearch, persist-console) refactored. The modules that still need to be refactored have been temporarily removed from the maven build plan in the branch. Once we get all of the contrib modules converted, reactivated, and informally tested, i'll support merging the branch into master. Steve On Fri, Feb 21, 2014 at 1:11 PM, Ryan Ebanks (JIRA) <[email protected]> wrote: > Ryan Ebanks created STREAMS-26: > ---------------------------------- > > Summary: Create a framework to run an Activity stream in a > single JVM > Key: STREAMS-26 > URL: https://issues.apache.org/jira/browse/STREAMS-26 > Project: Streams > Issue Type: Improvement > Reporter: Ryan Ebanks > Assignee: Ryan Ebanks > > > I implemented a way to run activity streams in JVM through a single. I > borrowed several concepts from the Apache Storm project as far as how to > declare a stream. The result is some interface changes, and a builder class > that will construct and run your activity stream. > > > > -- > This message was sent by Atlassian JIRA > (v6.1.5#6160)
