Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/4#discussion_r12044284
  
    --- Diff: 
streams-pojo/src/main/java/org/apache/streams/data/util/RFC3339Utils.java ---
    @@ -54,6 +56,68 @@ public static RFC3339Utils getInstance(){
         public static final DateTimeFormatter LOCAL_STANDARD_FMT = 
DateTimeFormat.forPattern(BASE_FMT + "Z").withZoneUTC();
         public static final DateTimeFormatter LOCAL_SUB_SECOND_FMT = 
DateTimeFormat.forPattern(BASE_FMT + ".SSSZ").withZoneUTC();
     
    +    /**
    +     * Contains various formats.  All formats should be of international 
standards when comes to the ordering of the
    +     * days and month.
    +     */
    +    private static final  DateTimeFormatter DEFAULT_FORMATTER;
    +    /**
    +     * Contains alternative formats that will succeed after failures from 
the DEFAULT_FORMATTER.
    +     * i.e. 4/24/2014 will throw an exception on the default formatter 
because it will assume international date standards
    +     * However, the date will parse in the ALT_FORMATTER because it 
contains the US format of MM/dd/yyyy.
    +     */
    +    private static final DateTimeFormatter ALT_FORMATTER;
    +
    +    static {
    +        DateTimeParser[] parsers = new DateTimeParser[]{
    +                DateTimeFormat.forPattern("EEE MMM dd HH:mm:ss Z 
yyyy").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd MMMM yyyy 
HH:mm:ss").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("yyyyMMdd").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("dd-MM-yyyy").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("yyyy-MM-dd").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("yyyy/MM/dd").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd MMM 
yyyy").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd MMMM 
yyyy").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("yyyyMMddHHmm").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("yyyyMMdd 
HHmm").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd-MM-yyyy 
HH:mm").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("yyyy-MM-dd 
HH:mm").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("yyyy/MM/dd 
HH:mm").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd MMM yyyy 
HH:mm").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd MMMM yyyy 
HH:mm").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("yyyyMMddHHmmss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("yyyyMMdd 
HHmmss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd-MM-yyyy 
HH:mm:ss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("yyyy-MM-dd 
HH:mm:ss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("yyyy/MM/dd 
HH:mm:ss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd MMM yyyy 
HH:mm:ss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("HH:mm:ss 
yyyy/MM/dd").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("HH:mm:ss 
MM/dd/yyyy").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("HH:mm:ss 
yyyy-MM-dd").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("HH:mm:ss 
MM-dd-yyyy").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd/MM/yyyy 
HH:mm:ss").withZoneUTC().getParser(),
    +                DateTimeFormat.forPattern("dd/MM/yyyy 
HH:mm").withZoneUTC().getParser(),
    +                
DateTimeFormat.forPattern("dd/MM/yyyy").withZoneUTC().getParser(),
    +                UTC_STANDARD_FMT.getParser(),
    +                UTC_SUB_SECOND_FMT.getParser(),
    +                LOCAL_STANDARD_FMT.getParser(),
    --- End diff --
    
    You can probably get rid of all the static fields except UTC_SUB_SECOND_FMT 
and just follow the pattern you set here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to