[
https://issues.apache.org/jira/browse/STREAMS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009776#comment-14009776
]
ASF GitHub Bot commented on STREAMS-93:
---------------------------------------
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/25#discussion_r13083214
--- Diff:
streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/serializer/TwitterJsonActivitySerializer.java
---
@@ -81,6 +87,86 @@ else if( documentSubType == Delete.class )
throw new NotImplementedException();
}
+ public static Actor buildActorRetweet(Retweet tweet) {
+ return buildActor(tweet.getUser());
+ }
+
+ public static Actor buildActorTweet(Tweet tweet) {
+ return buildActor(tweet.getUser());
+ }
+
+ public static Actor buildActor(User user) {
+ Actor actor = new Actor();
+
+ actor.setId(formatId(
+ Optional.fromNullable(
+ user.getIdStr())
+ .or(Optional.of(user.getId().toString()))
+ .orNull()
+ ));
+ actor.setDisplayName(user.getScreenName());
--- End diff --
If it is in the extensions already, I suggest leave it there for now, but
we should have a separate conversation on the list about how we handle this
> Add generic extensions from multiple providers
> ----------------------------------------------
>
> Key: STREAMS-93
> URL: https://issues.apache.org/jira/browse/STREAMS-93
> Project: Streams
> Issue Type: Task
> Reporter: Robert Douglas
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At the moment, if we want to grab out things like "hashtags" or "Number of
> Likes" from an activity, we have to delve into that provider's extension. So,
> for example, "extensions.twitter.entities.hashtags.text". There are certain
> attributes that are consistent across multiple providers and could benefit
> from being placed at the top level of the "extensions" attribute.
> These would include things like "hashtags", "rebroadcasts", "likes",
> "user_mentions", and "urls"
--
This message was sent by Atlassian JIRA
(v6.2#6252)
