[
https://issues.apache.org/jira/browse/STREAMS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011263#comment-14011263
]
ASF GitHub Bot commented on STREAMS-80:
---------------------------------------
Github user rbnks commented on the pull request:
https://github.com/apache/incubator-streams/pull/15#issuecomment-44430371
Closing this out and moving discussion to the list serve is fine.
As far as the issue of processors/writers running other threads the task is
unaware of should not be an issue. The task calls cleanUp() on all components
before exiting, and it should be the components responsibility to shut down any
of its threads and/or async tasks. If the processor/writer is not emptying
internal queues and shutting down threads that is an error in the
processor/writer.
> StreamsProcressorTask and StreamsPersistWriterTask are BROKEN
> -------------------------------------------------------------
>
> Key: STREAMS-80
> URL: https://issues.apache.org/jira/browse/STREAMS-80
> Project: Streams
> Issue Type: Bug
> Reporter: Ryan Ebanks
> Priority: Critical
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> A recent commit seems to have introduced this. Its a simple fix, but the
> while statement on line 70 of StreamsProviderTask should read
> while(this.keepRunning.get() || datum != null) {
> And line 75 in StreamsPersist writer task should read
> while(this.keepRunning.get() || datum != null) {
> Both lines are missing the datum != null statement. This causes tasks to be
> shutdown before data is processed and data is orphaned in the stream. In the
> worst case only the provider runs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
