Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/61#discussion_r15810478
--- Diff:
streams-contrib/streams-persist-elasticsearch/src/main/java/org/apache/streams/elasticsearch/ElasticsearchConfigurator.java
---
@@ -78,28 +78,14 @@ public static ElasticsearchReaderConfiguration
detectReaderConfiguration(Config
public static ElasticsearchWriterConfiguration
detectWriterConfiguration(Config elasticsearch) {
- ElasticsearchConfiguration elasticsearchConfiguration =
detectConfiguration(elasticsearch);
- ElasticsearchWriterConfiguration elasticsearchWriterConfiguration
= mapper.convertValue(elasticsearchConfiguration,
ElasticsearchWriterConfiguration.class);
-
- String index = elasticsearch.getString("index");
- String type = elasticsearch.getString("type");
- Long maxMsBeforeFlush =
elasticsearch.hasPath("MaxTimeBetweenFlushMs") ?
elasticsearch.getLong("MaxTimeBetweenFlushMs") : null;
-
- if( elasticsearch.hasPath("bulk"))
-
elasticsearchWriterConfiguration.setBulk(elasticsearch.getBoolean("bulk"));
-
- if( elasticsearch.hasPath("batchSize"))
-
elasticsearchWriterConfiguration.setBatchSize(elasticsearch.getLong("batchSize"));
-
- if( elasticsearch.hasPath("batchBytes"))
-
elasticsearchWriterConfiguration.setBatchBytes(elasticsearch.getLong("batchBytes"));
-
-
- elasticsearchWriterConfiguration.setIndex(index);
- elasticsearchWriterConfiguration.setType(type);
-
elasticsearchWriterConfiguration.setMaxTimeBetweenFlushMs(maxMsBeforeFlush);
-
+ ElasticsearchWriterConfiguration elasticsearchWriterConfiguration
= null;
+ try {
+ elasticsearchWriterConfiguration =
mapper.readValue(elasticsearch.root().render(ConfigRenderOptions.concise()),
ElasticsearchWriterConfiguration.class);
--- End diff --
Won't this not work as the Typesafe config is not always valid JSON?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
