[
https://issues.apache.org/jira/browse/STREAMS-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139082#comment-14139082
]
ASF GitHub Bot commented on STREAMS-178:
----------------------------------------
Github user sieverssj commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/90#discussion_r17735841
--- Diff:
streams-contrib/streams-processor-urls/src/test/java/org/apache/streams/urls/TestLinkUnwinderProcessor.java
---
@@ -76,8 +76,8 @@ public void testActivityLinkUnwinderProcessorGoDaddy()
throws Exception{
@Test
public void testActivityLinkUnwinderProcessorMulti() throws Exception{
- testActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt";,
"http://ow.ly/u4Kte";, "http://goo.gl/wSrHDA";),
Lists.newArrayList("http://www.wcgworld.com/";, "http://www.wcgworld.com/";,
"http://www.wcgworld.com/";));
-
testStringActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt";,
"http://ow.ly/u4Kte";, "http://goo.gl/wSrHDA";),
Lists.newArrayList("http://www.wcgworld.com/";, "http://www.wcgworld.com/";,
"http://www.wcgworld.com/";));
+ testActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt";,
"http://ow.ly/u4Kte";, "http://goo.gl/wSrHDA";),
Lists.newArrayList("http://www.wcgworld.com/";));//, "http://www.wcgworld.com/";,
"http://www.wcgworld.com/";));
--- End diff --
Small nit: Get rid of the commented out code on the end of these lines.
Assuming that happens, :+1:
> LinkResolverProcessor should return a set of unwound links
> ----------------------------------------------------------
>
> Key: STREAMS-178
> URL: https://issues.apache.org/jira/browse/STREAMS-178
> Project: Streams
> Issue Type: Bug
> Reporter: Robert Douglas
>
> The LinkResolverProcessor currently returns unwound links in a List. This is
> problematic because in the event that more than one of the shortened links
> results in the same unwound link, we end up with a list of duplicates. To
> mediate this issue, the LinkResolverProcessor's unwind function should return
> a Set of unwound links, guaranteeing that they are all unique.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
