[ 
https://issues.apache.org/jira/browse/STREAMS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145384#comment-14145384
 ] 

ASF GitHub Bot commented on STREAMS-182:
----------------------------------------

Github user mfranklin commented on the pull request:

    https://github.com/apache/incubator-streams/pull/93#issuecomment-56584748
  
    :+1: 


> AbstractRegexExtensionExtractor needs to fix memory reference issue
> -------------------------------------------------------------------
>
>                 Key: STREAMS-182
>                 URL: https://issues.apache.org/jira/browse/STREAMS-182
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
>
> The ensureTargetObject function in AbstractRegexExtensionExtractor does not 
> always ensure that the collection it returns is the collection that was 
> originally pointed to by the extensionKey.
> once the hashtags set has been created (either via 
> Sets.newHashSet((Iterable<T>) extensions.get(extensionKey)) or 
> Sets.newHashSet() depending on if it was already present) then it needs to be 
> reassigned to the extensionKey. This will make sure that any modifications to 
> the hashtags Set will be reflected in the final Activity Object



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to