[
https://issues.apache.org/jira/browse/STREAMS-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191891#comment-14191891
]
ASF GitHub Bot commented on STREAMS-199:
----------------------------------------
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/109#discussion_r19671069
--- Diff:
streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
---
@@ -111,14 +113,18 @@ public void run() {
Thread.currentThread().interrupt();
}
if(datum != null) {
+ this.counter.incrementReceivedCount();
try {
+ long startTime = System.currentTimeMillis();
this.writer.write(datum);
+ this.counter.addTime(System.currentTimeMillis() -
startTime);
statusCounter.incrementStatus(DatumStatus.SUCCESS);
} catch (Exception e) {
LOGGER.error("Error writing to persist writer {}",
this.writer.getClass().getSimpleName(), e);
this.keepRunning.set(false); // why do we shutdown
on a failed write ?
--- End diff --
This out of the scope of this pull request, and is not a change made by
this pull request. but we can open a ticket to make this change.
> Implement new Changes to StreamTasks
> ------------------------------------
>
> Key: STREAMS-199
> URL: https://issues.apache.org/jira/browse/STREAMS-199
> Project: Streams
> Issue Type: Sub-task
> Reporter: Ryan Ebanks
>
> Implement new Changes to StreamTasks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)