Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/203#discussion_r27491480
  
    --- Diff: 
streams-components/streams-http/src/main/java/org/apache/streams/components/http/persist/SimpleHTTPPostPersistWriter.java
 ---
    @@ -113,13 +113,14 @@ protected ObjectNode preparePayload(StreamsDatum 
entry) {
         public HttpPost prepareHttpPost(URI uri, ObjectNode payload) {
             HttpPost httppost = new HttpPost(uri);
             httppost.addHeader("content-type", 
this.configuration.getContentType());
    +        httppost.addHeader("accept-charset", "UTF-8");
             try {
                 String entity = mapper.writeValueAsString(payload);
                 httppost.setEntity(new StringEntity(entity));
             } catch (JsonProcessingException e) {
    -            e.printStackTrace();
    +            LOGGER.warn(e.getMessage());
    --- End diff --
    
    What's the thinking about these being warnings here? Seems like it's a 
bonafide error if it fails to writeValueAsString.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to