[
https://issues.apache.org/jira/browse/STREAMS-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388877#comment-14388877
]
ASF GitHub Bot commented on STREAMS-259:
----------------------------------------
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/207#discussion_r27501388
--- Diff:
streams-components/streams-filters/src/main/java/org/apache/streams/filters/VerbDefinitionDropFilter.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.streams.filters;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import org.apache.streams.core.StreamsDatum;
+import org.apache.streams.core.StreamsProcessor;
+import org.apache.streams.pojo.json.Activity;
+import org.apache.streams.verbs.ObjectCombination;
+import org.apache.streams.verbs.VerbDefinition;
+import org.apache.streams.verbs.VerbDefinitionResolver;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Checks one or more verb definitions against a stream of Activity
documents, and drops any activities
+ * which match the filter criteria.
+ */
+public class VerbDefinitionDropFilter implements StreamsProcessor {
+
+ private static final String STREAMS_ID = "VerbDefinitionDropFilter";
+ private static final Logger LOGGER =
LoggerFactory.getLogger(VerbDefinitionDropFilter.class);
+
+ protected Set<VerbDefinition> verbDefinitionSet;
+ protected VerbDefinitionResolver resolver;
+
+ public VerbDefinitionDropFilter() {
+ // get with reflection
+ }
+
+ public VerbDefinitionDropFilter(Set<VerbDefinition> verbDefinitionSet)
{
+ this();
+ this.verbDefinitionSet = verbDefinitionSet;
+ }
+
+ @Override
+ public List<StreamsDatum> process(StreamsDatum entry) {
+
+ List<StreamsDatum> result = Lists.newArrayList();
+
+ LOGGER.debug("{} filtering {}", STREAMS_ID,
entry.getDocument().getClass());
+
+ Activity activity;
+
+ Preconditions.checkArgument(entry.getDocument() instanceof
Activity);
+
+ activity = (Activity) entry.getDocument();
+
+ boolean match = false;
+ for( VerbDefinition verbDefinition : verbDefinitionSet)
+ if( verbDefinition.getValue() != null &&
+ verbDefinition.getValue().equals(activity.getVerb()))
+ for (ObjectCombination objectCombination :
verbDefinition.getObjects())
+ if (VerbDefinitionResolver.filter(activity,
objectCombination) == true)
+ match = true;
--- End diff --
don't you want to break on the first match so that you don't have to test
any additional values?
> Filter a stream of Activities for specific verbs and objectTypes
> ----------------------------------------------------------------
>
> Key: STREAMS-259
> URL: https://issues.apache.org/jira/browse/STREAMS-259
> Project: Streams
> Issue Type: New Feature
> Reporter: Steve Blackmon
> Assignee: Steve Blackmon
>
> Provide a way to define and apply a filter to a stream to pass along only
> activities with defined verbs and objectTypes in specific fields.
> Verb Definitions appear to be a good way to specify and identify filtering
> rules.
> https://raw.github.com/activitystreams/activity-streams-verb-definition/master/activity-streams-verb-definition.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
