Github user eponvert commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/263#discussion_r42376075
--- Diff:
streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProviderTask.java
---
@@ -144,6 +165,57 @@ else if( endpoint.equals("friends") )
} while (curser != 0 && keepTrying < 10);
}
+ private void collectIds(Long id) {
+ int keepTrying = 0;
+
+ long curser = -1;
+
+ do
+ {
+ try
+ {
+ twitter4j.IDs ids = null;
+ if( endpoint.equals("followers") )
+ ids =
client.friendsFollowers().getFollowersIDs(id.longValue(), curser, max_per_page);
+ else if( endpoint.equals("friends") )
+ ids =
client.friendsFollowers().getFriendsIDs(id.longValue(), curser, max_per_page);
+
+ Preconditions.checkNotNull(ids);
--- End diff --
This is a little roundabout, right? The conditions where `ids == null` is
where either `!endpoint.equals("followers")` or `!endpoint.equals("friends")`.
Really the Preconditions should be checking *that*, and throwing a more verbose
exception in the case it fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
