[ https://issues.apache.org/jira/browse/STREAMS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963372#comment-14963372 ]
ASF GitHub Bot commented on STREAMS-371: ---------------------------------------- Github user eponvert commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/263#discussion_r42376204 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProviderTask.java --- @@ -144,6 +165,57 @@ else if( endpoint.equals("friends") ) } while (curser != 0 && keepTrying < 10); } + private void collectIds(Long id) { + int keepTrying = 0; + + long curser = -1; + + do + { + try + { + twitter4j.IDs ids = null; + if( endpoint.equals("followers") ) + ids = client.friendsFollowers().getFollowersIDs(id.longValue(), curser, max_per_page); + else if( endpoint.equals("friends") ) + ids = client.friendsFollowers().getFriendsIDs(id.longValue(), curser, max_per_page); + + Preconditions.checkNotNull(ids); + Preconditions.checkArgument(ids.getIDs().length > 0); --- End diff -- Similarly, don't you probably want to know whether it was `client.friendsFollowers()` or `client.friendsFollowers()` that produced empty results, rather than checking this variable here? > Allow use of ids endpoints in TwitterFollowingProvider > ------------------------------------------------------ > > Key: STREAMS-371 > URL: https://issues.apache.org/jira/browse/STREAMS-371 > Project: Streams > Issue Type: Improvement > Reporter: Steve Blackmon > Assignee: Steve Blackmon > > Allow use of ids endpoints in TwitterFollowingProvider > These ids have higher throughput than the endpoints the provider currently > uses, at the cost of getting only IDs rather than full profiles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)