Date: 2004-09-17T07:53:09 Editor: NiallPemberton <[EMAIL PROTECTED]> Wiki: Apache Struts Wiki Page: StrutsCatalogSimpleDispatchAction URL: http://wiki.apache.org/struts/StrutsCatalogSimpleDispatchAction
no comment Change Log: ------------------------------------------------------------------------------ @@ -400,3 +400,25 @@ ---- '''Unfortunately, Niall, you assumed for some reason I was talking about your code. I was not talking about your code. Notice that I did not subclass DispatchAction in SimpleDispatchAction so there could have been no code bloat. In fact, I did not subclass DispatchAction because I don't like the code bloat in that Action. I was talking about your understanding of this class. I wish you would slow down and see what is going on before making all these decisions. I suppose calmer reflection will eventually prevail but presently you are doing things while clearly misapprehending what is going on with this class. You might take some pause at that statement, since I am the author of the class in the frist instance. However, as I said, time will tell. I think I know my class alright.''' + +---- + + * I did notice that your SimpleDispatchAction didn't subclass DispatchAction and my comment about code bloat is just the fact that you have duplicated almost everything in DispatchAction in your SimpleDispatchAction rather than sub-classing it and re-using the code. The only ''real'' difference is in the contents of the getMethodName() method. Comparing the SimpleDispatchAction methods to DispatchAction: + + * execute() - same code '''except''' SimpleDispatchAction doesn't handle cancelled and doesn't retrieve a parameter from the action mapping. + * unspecified() - identical to DispatchAction + * cancelled() - identical to DispatchAction + * dispatchMethod() - identical to DispatchAction + * getMethod() - identical to DispatchAction + + + + * I don't see any 'bloat' in DispatchAction and think you're talking nonsense. + + * I'm not making any decisions - just taking part in a debate - so I don't understand that comment. + + * Seems to me that its you thats misapprehending whats going on and I can't understand why you can't see that SimpleDispatchAction is ''almost'' identical to DispatchAction. + + +'''Niall Pemberton''' + --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
