DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=866>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=866 ------- Additional Comments From [EMAIL PROTECTED] 2004-12-23 03:59 ------- Don, +1 to doing something about this. I agree with leaving out the ActionErrors/ActionMessages - another solution to that issue which has been discussed on the list is to pop them into Session scope before the re-direct and then remove them afterwards. That seems a more straight forward solution and there is a saveMessages() method in Action which stores and removes them from the session. IMO it would be neat to be able to specify parameters for a forward in the struts-config. Something like... <forward name="myForward" path="/myPath"> <parameter name="foo" value="bar"/> </forward> ...so rather than having a "re-direct" specific implementation, maybe it should be merged into ForwardConfig instead? More specific comments on Hubert's solution (kudos to him for actually submitting code!).... * The TagUtils computeURLWithCharEncoding() method does a similar process of adding parameters to a path - maybe we should re-factor the utils so that both that method and this requirement can be satisfied. * Hubert's solution uses the JDK 1.4 encode method - there is already a solution to in TagUtils - it has an encodeURL() method which tries first to use a 1.4 encoding method before re-verting to the deprecated 1.3 method. I'm also wondering if the getPath() method is the right place to have any encoding at all - maybe this should be done in the RequestProcessor where the Request is available and a local encoding from the Request could be taken into account - in the way that the TagUtils computeURLWithCharEncoding() does? * I would prefer the minimalist approach to the API and just have one addParameter() method and not include all the 'convienece' methods to cater for the primitives. Niall P.S. Seems to me that some of the stuff in TagUtils isn't specific to Tags and maybe needs moving/refactoring into some 'core' struts utils (RequestUtils?). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
