I think you're using the wrong version of the Tiles Plugin. For Struts 1.3, Tiles has been pulled out to

http://svn.apache.org/repos/asf/struts/tiles

and the head version of the plugin is at
http://svn.apache.org/repos/asf/struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesPlugin.java

As far as I'm concerned, that compatibility check should be completely removed. I don't like the TilesPlugIn changing things like that, and I think people could learn quickly enough that they have to specify a different RequestProcessor if they want to use Tiles.

Actually, on my way into work this morning, the whole idea of making Tiles a standalone project really clicked for me; I'd love to see Struts become completely ignorant of Tiles, simply having a TilesServlet handle request dispatches for a standard mapping like "*.tiles". My understanding is that this, or something like it, is in the works, but I don't think the principal instigators have found much time yet to move forward on it. So it probably wouldn't come to pass until Struts 1.4 or later.

But, in short, you're right.

"Determines if the class or interface represented by this Class object is either the same as, or is a superclass or superinterface of, the class or interface represented by the specified Class parameter. It returns true if so; otherwise it returns false. If this Class object represents a primitive type, this method returns true if the specified Class parameter is exactly this Class object; otherwise it returns false."
http://java.sun.com/j2se/1.5.0/docs/api/java/lang/Class.html#isAssignableFrom(java.lang.Class)


Joe

At 9:51 AM +0100 2/4/05, Wolfgang Gehner wrote:
Hi Guys,

I am testing Struts 1.3 with Tiles.

I see

http://svn.apache.org/viewcvs.cgi/struts/core/trunk/src/share/org/apache/struts/tiles/TilesPlugin.java?rev=57589&view=markup

and think that the test(s)

tilesProcessorClass.isAssignableFrom(configProcessorClass)

should be inverted, as in:

configProcessorClass.isAssignableFrom(tilesProcessorClass)

IsAssignable is the inversion of "extends", and I guess the test should be
if tilesProcessorClass extends configProcessorClass, i.e.


Best regards,

Wolfgang Gehner
Co-author "Struts Best Practices"
http://www.amazon.de/exec/obidos/ASIN/3898642844
http://www.amazon.fr/exec/obidos/ASIN/2100486357

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


--
Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to