I guess it's debatable. As 99.9% of similar code in the EL tags uses a consistent pattern, a comment should be added to this block saying why this diverges from the pattern. Someone scanning the code would wonder why this one was different.
> -----Original Message----- > From: James Mitchell [mailto:[EMAIL PROTECTED] > > It's just one of many things Eclipse is yelling at me. Look at > IncludeTag.setName(), it's simply doing this.page = name in > the setter. Am > I wrong to change this? > > ----- Original Message ----- > From: "Karr, David" <[EMAIL PROTECTED]> > > Could you clarify this a bit? You now have two different attributes, > "name" and "page", that both will be setting the "page" > attribute in the > superclass. Is that what you intend to happen? > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > > URL: http://svn.apache.org/viewcvs?view=rev&rev=154023 > > Log: > > change to setPage since setName is depracated > ============================================================== > --- > struts/el/trunk/src/share/org/apache/strutsel/taglib/bean/ELIn > cludeTag.j > ava (original) > +++ > struts/el/trunk/src/share/org/apache/strutsel/taglib/bean/ELIncludeT > +++ ag.java Wed Feb 16 06:48:25 2005 > @@ -196,7 +196,7 @@ > > if ((string = EvalHelper.evalString("name", getNameExpr(), > this, pageContext)) != > null) > - setName(string); > + setPage(string); > > if ((string = EvalHelper.evalString("page", getPageExpr(), > this, pageContext)) != > null) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
