At 9:07 AM -0600 2/22/05, Hubert Rabago wrote:
I tried this over the weekend, starting with form beans.
Here's what my sample app had:

Hubert: the description of intent for the XML is right-on.

The extension gets realized before the loop which creates and
registers the DynaActionFormClass instances.  This code is still
in the ActionServlet.initModuleConfig() method, so I've extracted
this into its own method.  Simple checks for circular inheritance
can be easily done by FormBeanConfig, but more complex checking
should probably be done by a separate method in ActionServlet, or
maybe in a util class, such as ModuleUtils.

Comments, please.

Now may not be the time, but my long-term preference would be to extract as much as possible out of the ActionServlet, so that it simply becomes a choreographer. I think this is a good pre-cursor to having more flexible options for how to configure Struts (as well as forcing us to be more deliberate about where we permit dependencies on the Servlet API). From a purely conceptual standpoint, I almost think that everything inside initModuleConfig() should be moved into the ModuleConfigFactory.


But in the meantime, I think putting it in ModuleUtils is probably better than having it in the ActionServlet itself.

I don't know if other people share my opinions about this.

Joe

--
Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to