----- Original Message ----- From: "Martin Cooper" <[EMAIL PROTECTED]> Sent: Friday, February 25, 2005 4:25 AM
> On Fri, 25 Feb 2005 04:15:17 -0000, Niall Pemberton > <[EMAIL PROTECTED]> wrote: > > AFAIK there were two issues with multipart request handling that needed > > Servlet 2.3 to resolve: > > > > 1) Forwarding a "wrapped" Request > > http://issues.apache.org/bugzilla/show_bug.cgi?id=17583 > > > > 2) Un-implemented Servlet 2.3 methods > > http://issues.apache.org/bugzilla/show_bug.cgi?id=28983 > > > > I think we agreed to move to Servlet 2.3 now(?), so all thats needed to > > resolve both of these is: > > > > 1) Change the MultipartRequestWrapper to extend the > > HttpServletRequestWrapper (and remove the un-implemented Servlet 2.3 > > methods) > > 2) Remove the "un-wrapping" code from the PerformForward Command (anywhere > > else?) > > > > Anyone have any objections/issues to doing this? > > Not really. However, if we end up going with the filter and wrapper > I'm working on (slowly!) for Commons FileUpload, we wouldn't > necessarily need our own wrapper. The changes are pretty minor and if your Commons stuff arrives in time, we can simply remove the wrapper from Struts. What do you think about factoring the multipart handling in a command for backwards compatibility. Also it would give the users two options - Command or Filter? As long as both work in the same way, so that when the population mechanism is hit either would work. Another thought - rather than putting the FormFile fields in the wrapper another approach is to put the Multipart handler in the request (I think we already do this) and have the populate mechanims retrieve the FormFile fields from the handler. > Also, you might want to add dummy methods for the new ones added in > Servlets 2.4, so that we're compatible there too. Not sure if there's > a bug in Bugzilla for that, but it's come up on the lists before. If were inheriting from HttpServletRequestWrapper then anyone running on Servlet 2.4 will have "proper" implementations of those methods available? Adding 'dummy' implementation methods would just mean that those methods wouldn't work for Servlet 2.4 implementations. > -- > Martin Cooper > > > > Niall --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
