On Wed, 16 Mar 2005 08:02:32 -0600, Joe Germuska <[EMAIL PROTECTED]> wrote:So, if I have a way to get my own ActionContext into my actions, then I'm less concerned about the current mechanism for specifying a custom ActionContext. I'd want to hear more on the ActionContextFactory threads before making any changes there...
An ActionContextFactory sounds fine to me. ...But, I don't know if we need to do that in Struts 1.3.0.
I agree. And ComposableRequestProcessor already isolates the production of the ActionContext in a way that one can introduce an alternate implementation - the extensibility is already there, but Bill S. didn't like it. I hope he gets a chance to respond with some more insight as to why he prefers an explicit Factory class. I can see where one might say that extending RequestProcessor for this compounds the problems we already had, but then, ComposableRequestProcessor does so little else right now (deferring almost everything to the chain it invokes) that I almost feel like it's more straightforward to extend it than to add an entirely new factory process. Still, I just did what was expedient when I came to the conclusion that having a command wrap the context was not the best way to introduce the ActionContext. (As noted earlier, the WrappingLookupCommand is still in SVN, if someone wants to make the case that it's the better way.)
I'd also be good with using Spring as an IOC for Struts. I'm using it myself, and it works like a charm. The IOC strategy opens many doors.
Well, I'm certainly not pushing for Struts to formally use Spring in 1.3.0 (although I agree its a good candidate for the future.) In this case, I was just describing a particular use case in which I want access to the ActionContext inside an Action. This seems fundamental to the intentions an ActionContext class, even if the class was originally designed for the rest of the chain.
But, having suffered through the 1.1 death march, I'd be nervous about continuing with too many refactorings prior to rolling some type of an initial distribution.
Acknowledged. I'm just not ready to be a release manager, especially for Struts. If someone is ready to be the release manager, they can call a freeze and we can let some of this sit, but until then, I will keep making small changes and floating the bigger ideas here. (After all, I did refrain from changing Action for a second time last night, even though my instincts point to that as the right next step...)
Joe
--
Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
