StrutsInfo.java

Don Brown Sun, 27 Mar 2005 15:49:03 -0800

The reason all those methods are there is, in Action, they are listed as protected, and protected methods cannot be accessed by scripts. Scripts need public methods so I had to override every method and make it public. Second, BSF is targetting 1.1 so any changes should not impact working with Struts 1.1. Finally, please, go ahead and just remove/modify/add methods as you see fit since it is unreleased as Martin pointed out.

Don

James Mitchell wrote:

True, although released or not, removing them would have zero impact to any project using it.

Sorry for the simple noise on dev, I recently upgraded to Eclipse 3.0.2 and I'm getting all the Struts subprojects back into my development environment and just hitting some of the "low hanging fruit"....ok...more like "fruit that is already fallen to the ground, collected, and handed to me in boxes" ;)
--
James Mitchell
Software Engineer / Open Source Evangelist
Consulting / Mentoring / Freelance
EdgeTech, Inc.
678.910.8017
AIM:   jmitchtx
Yahoo: jmitchtx
MSN:   [EMAIL PROTECTED]
----- Original Message ----- From: "Martin Cooper" <[EMAIL PROTECTED]> To: "Struts Developers List" <[email protected]> Sent: Saturday, March 26, 2005 11:41 PM Subject: Re: svn commit: r159137 - struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java
On Sun, 27 Mar 2005 04:36:29 -0000, [EMAIL PROTECTED]
<[EMAIL PROTECTED]> wrote:
Author: jmitchell
Date: Sat Mar 26 20:36:28 2005
New Revision: 159137
URL: http://svn.apache.org/viewcvs?view=rev&rev=159137 Log: remove unused imports and deprecate saveErrors (although I'm not quite sure why it, and many others methods are here since all they do is call the super
AFAIK, Struts BSF hasn't been released yet, so we should be able to
just zap the methods instead of deprecating them.
--
Martin Cooper
Modified:
    struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java
    struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java
Modified: struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java URL: http://svn.apache.org/viewcvs/struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java?view=diff&r1=159136&r2=159137

==============================================================================

--- struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java (original) +++ struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java Sat Mar 26 20:36:28 2005 @@ -4,7 +4,6 @@ import java.util.*;
 import javax.servlet.ServletContext;
-import javax.servlet.ServletException;
 import javax.servlet.http.HttpSession;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
@@ -12,13 +11,17 @@
 import org.apache.bsf.BSFManager;
 import org.apache.bsf.BSFException;
 import org.apache.bsf.util.IOUtils;
-import org.apache.bsf.util.CodeBuffer;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
-import org.apache.struts.action.*;
-import org.apache.struts.util.MessageResources;
+import org.apache.struts.action.Action;
+import org.apache.struts.action.ActionErrors;
+import org.apache.struts.action.ActionForm;
+import org.apache.struts.action.ActionForward;
+import org.apache.struts.action.ActionMapping;
+import org.apache.struts.action.ActionMessages;
+
/** * This Action uses scripts to perform its action. The scripting framework is @@ -394,6 +397,8 @@ * [EMAIL PROTECTED] req The request object [EMAIL PROTECTED] errs The action errors + [EMAIL PROTECTED] Use saveErrors(HttpServletRequest, ActionMessages) instead. + * This will be removed after Struts 1.2. */ public void saveErrors(HttpServletRequest req, ActionErrors errs) { super.saveErrors(req, errs);

Modified: struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java URL: http://svn.apache.org/viewcvs/struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java?view=diff&r1=159136&r2=159137

==============================================================================

--- struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java (original) +++ struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java Sat Mar 26 20:36:28 2005 @@ -1,7 +1,6 @@ package org.apache.struts.bsf;
 import org.apache.struts.action.ActionForward;
-import org.apache.struts.action.Action;
 import org.apache.struts.action.ActionForm;
 import org.apache.struts.action.ActionMapping;
 import org.apache.struts.util.MessageResources;
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r159137 - struts/bsf/trunk/src/java/org/apache/struts/bsf/ScriptAction.java struts/bsf/trunk/src/java/org/apache/struts/bsf/StrutsInfo.java

Reply via email to