I can totally understand where some folks would not want ActionContext to get too weighed down, but it also seems like some of these would be really universally convenient. I thought I'd raise the general question and then depending on responses, potentially add some of these. One reason to be hesitant would be that ActionContext is an interface, so the more we add to it, the greater burden to anyone who would choose to implement it -- even if we also provide implementations in ActionContextBase.
Still, who could argue with something like this: public boolean hasErrors() { ActionMessages errors = this.getErrors(); return (errors != null && errors.size() > 0); }
On the other hand, some could probably argue with this: public void addGlobalError(String key) { ActionMessages msgs = new ActionMessages(); msgs.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage(key)); this.addErrors(msgs); }
Since I have a custom subclass of ActionContext for my app, I'm perfectly happy to implement these far away from the Struts core; however, if people think its for the common good to add some things along these lines, I would be happy to do that as well. If people can articulate any general philosophies, it might save from repeatedly seeing who thinks what is too much or just enough.
Joe
-- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]